Skip to content

feat: Implement Scene Viewer XR-style AR placement and scale toggle for world-space mode #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025

Conversation

samaneh-kazemi
Copy link
Collaborator

@samaneh-kazemi samaneh-kazemi commented Jul 10, 2025

Summary

This PR adds Scene Viewer XR (SVXR)-style world-space AR placement, scale toggle functionality, and Y-axis movement capability to model-viewer, improving the XR experience to match industry standards.

Changes

  • Initial Placement: Implemented optimal model placement logic for world-space AR that positions models at comfortable viewing distance and angle
  • Scale Limits: Added min/max scale calculation to prevent models from becoming too small or large
  • Scale Toggle: Added 1:1 scale toggle functionality that switches between initial scale and original model size
  • Y-Axis Movement: Enhanced model positioning to allow full Y-axis control after initial placement

Technical Details

  • Uses SVXR constants and algorithms for consistent behavior
  • Adds proper scale clamping to prevent extreme sizes
  • Enables Y-axis movement for more flexible model positioning
  • Maintains backward compatibility with existing screen-space AR

Testing

Tested on Meta Quest 3

  • Tested world-space AR initial placement with various model sizes
  • Verified scale toggle functionality works correctly
  • Confirmed scale limits prevent models from becoming too small or large
  • Validated smooth transitions between scales
  • Tested Y-axis movement for flexible model positioning

@StillOnMyWay
Copy link

What is SVXR?

@samaneh-kazemi samaneh-kazemi changed the title feat: Implement SVXR-style AR placement and scale toggle for world-space mode feat: Implement Scene Viewer XR-style AR placement and scale toggle for world-space mode Jul 11, 2025
@samaneh-kazemi samaneh-kazemi merged commit 2a6b88c into master Jul 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants